Maxey-
Exactly! What guns is the question. My caveat: I am not in the business, other than as a consumer who has bought, sold and traded over the course of nearly 4 decades.
Based on my limited experience, I would have to disagree with a general proposition that firearms are among the best investments. They are sound investments that pay great dividends if you use and enjoy them. Unlike the typical article of clothing, if cared for, a firearm can be used and enjoyed and then sold later. They do require care in use (condition is important to value) and safe careful storage and can be targeted by criminals (I have suffered one such loss in my lifetime making a very good safe and/or insurance a good idea).
Whether or not at a financial profit after taking into account inflation, that is the questions. During my lifetime I have seen a big change in our culture and the trend is more anti gun and fewer who accept firearms ownership as the norm. In some parts of the country you can still see a pick up with a rifle in window, but that is now pretty much a thing of the past.
The future demand is not easy to predict, that there is a fairly adequate supply firearms out there and increasing regulation coupled with fewer and fewer places to shoot, might not bode well for anyone very heavily and generally and for the long term invested in firearms. Absent a complete prohibition, some firearms will no doubt appreciate due to increased demand and limited supply, but one must correctly predict the future.
This issue has been discussed in this forum in the past, and I must agree with what has already been said by others, and that is most individuals who actually make money on firearms will buy them low and sell them quickly at a profit and do not purchase firearms as long term investments.
Doug