You make no money in the stock market until you sell your stocks and pay your taxes. Most of the increases you are seeing is from large investors, not individual ones, like retirement funds and mutual funds or hedge funds. So if your retirement fund triples ten years before you retire, it does not mean you have anymore disposable income to use now, plus why you be spending that money on guns now instead of letting it continue to grow. It is the same problem with increasing land prices and better housing prices. You don't make any money until you sell. Been land poor for many years as they say.
So I am not surprised to see no direct relationship between rising stock prices and gun prices. just as I don't tie them to land or housing prices. What I do worry about is that baby boomers are aging fast and when they get out of the gun hobby there will be a glut of guns on the market, with fewer buyers interested in them, for many of the reasons others have mention above. Same thing for silver flatware, fine china, antiques of all kinds. The future market is not rosy for everything.