I have made real money on only two guns in all my years of buying and selling over 60 (though I am not sure of the number) guns.  Of the guns I have now I have no doubt I would continue to lose a little.
I believe previous posters have nailed it well in terms of harm:
1.  Potential addiction causes stupid priorities for spending
2.  Not a great investment, (all money made on a gun for me has been at purchase, all losses are gun rent in my mind)
3.  Creates a estate problem for the heirs (like what will an heir do with over a hundred military rifles from musket through modern without real knowledge of worth and even with it the logistics of storing and or selling?)
All said collecting can be a joy, but mostly to the collector. That said all things in moderation.