Gunsmithing vises that is.

What makes a good vise? Or what makes one vise better for gunsmithing than another.

For me, Ive got a couple of requirements:
They dont break easily, Ive busted a couple of cheap import bench vises, and more than a few import milling machine vises before I wised up.

And for me a bench vise must swivel.

Your thoughts